From 8b6acceda8bbc511b4b871afa81264280eef2998 Mon Sep 17 00:00:00 2001
From: "Michael N. Lipp" <mnl@mnl.de>
Date: Mon, 13 May 2024 22:33:05 +0200
Subject: [PATCH] Re-enable PMD.

---
 org.jdrupes.vmoperator.common/.eclipse-pmd    |  2 +-
 .../.eclipse-pmd                              |  2 +-
 org.jdrupes.vmoperator.manager/.eclipse-pmd   |  2 +-
 .../.eclipse-pmd                              |  2 +-
 org.jdrupes.vmoperator.util/.eclipse-pmd      |  2 +-
 org.jdrupes.vmoperator.vmconlet/.eclipse-pmd  |  2 +-
 ruleset.xml                                   | 20 ++++++++++---------
 spice-squid/.eclipse-pmd                      |  2 +-
 8 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/org.jdrupes.vmoperator.common/.eclipse-pmd b/org.jdrupes.vmoperator.common/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.common/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.common/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/org.jdrupes.vmoperator.manager.events/.eclipse-pmd b/org.jdrupes.vmoperator.manager.events/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.manager.events/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.manager.events/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/org.jdrupes.vmoperator.manager/.eclipse-pmd b/org.jdrupes.vmoperator.manager/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.manager/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.manager/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/org.jdrupes.vmoperator.runner.qemu/.eclipse-pmd b/org.jdrupes.vmoperator.runner.qemu/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.runner.qemu/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.runner.qemu/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/org.jdrupes.vmoperator.util/.eclipse-pmd b/org.jdrupes.vmoperator.util/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.util/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.util/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/org.jdrupes.vmoperator.vmconlet/.eclipse-pmd b/org.jdrupes.vmoperator.vmconlet/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/org.jdrupes.vmoperator.vmconlet/.eclipse-pmd
+++ b/org.jdrupes.vmoperator.vmconlet/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>
diff --git a/ruleset.xml b/ruleset.xml
index b362eb8..365c409 100644
--- a/ruleset.xml
+++ b/ruleset.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0"?>
 
 <ruleset name="Custom Rules"
-    xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+        xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
     <description>
 JGrapes rules
     </description>
@@ -27,14 +27,16 @@ JGrapes rules
         <exclude name="DefaultPackage"/>
         <exclude name="CallSuperInConstructor"/>
         <exclude name="AbstractNaming"/>
+        <exclude name="UseExplicitTypes"/>
     </rule>
     <rule ref="category/java/codestyle.xml/LongVariable">
       <properties>
          <property name="minimum" value="25" />
       </properties>
     </rule>
-    <rule ref="category/java/codestyle.xml/VariableNamingConventions">
+    <rule ref="category/java/codestyle.xml/FieldNamingConventions">
         <properties>
+            <property name="exclusions" value="serialVersionUID,serialPersistentFields,logger" />
             <property name="violationSuppressRegex" 
                 value="^.*'logger' is not all capitals."/>
         </properties>
@@ -45,6 +47,11 @@ JGrapes rules
                 value="Avoid variables with short names like id"/>
         </properties>
     </rule>
+    <rule ref="category/java/codestyle.xml/LinguisticNaming">
+        <properties>
+            <property name="checkSetters" value="false" />
+        </properties>
+    </rule>
     
     <rule ref="category/java/design.xml">
         <exclude name="LawOfDemeter"/>
@@ -90,11 +97,6 @@ JGrapes rules
         <exclude name="NullAssignment"/>
         <exclude name="UseProperClassLoader"/>
     </rule>
-    <rule ref="category/java/errorprone.xml/DataflowAnomalyAnalysis">
-        <properties>
-            <property name="violationSuppressRegex" value="^Found 'UR'-anomaly.*"/>
-        </properties>
-    </rule>
     
     <rule ref="category/java/multithreading.xml">
         <exclude name="DoNotUseThreads"/>
diff --git a/spice-squid/.eclipse-pmd b/spice-squid/.eclipse-pmd
index 8b394f8..5d69caa 100644
--- a/spice-squid/.eclipse-pmd
+++ b/spice-squid/.eclipse-pmd
@@ -2,6 +2,6 @@
 <eclipse-pmd xmlns="http://acanda.ch/eclipse-pmd/0.8" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://acanda.ch/eclipse-pmd/0.8 http://acanda.ch/eclipse-pmd/eclipse-pmd-0.8.xsd">
   <analysis enabled="true" />
   <rulesets>
-    <ruleset name="Custom Rules" ref="moodle-tools-console/ruleset.xml" refcontext="workspace" />
+    <ruleset name="Custom Rules" ref="VM-Operator/ruleset.xml" refcontext="workspace" />
   </rulesets>
 </eclipse-pmd>